[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option |
Date: |
Thu, 4 Jan 2018 16:59:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 04.01.2018 16:47, Paolo Bonzini wrote:
> On 04/01/2018 16:35, Thomas Huth wrote:
>>> Well, why not, it just doesn't seem to me much simpler than
>>> "-serial braille" and "-device usb-braille" :)
>>
>> FWIW, I think I'd also rather prefer to add some little bit of "magic"
>> to "-device usb-braille" instead of introducing yet another command line
>> parameter. QEMU's command line interface is already way too much
>> overcrowded, so IMHO we should try to avoid new parameters if possible.
>
> The point of deprecation is not to make the interface simpler, it is to
> avoid cases where one option is doing too much and/or crossing
> abstraction boundaries, for example -net creating both a device and a
> hub port.
>
> "-serial" is okay because it only creates the front-end, it's the board
> that decides how to attach it to the back-end.
>
> -usbdevice creating both a front-end and a back-end is not a problem per
> se. The issue with -usbdevice is just that it's too much code.
>
> However, adding magic to "-device usb-braille" that creates both a
> front-end and a back-end is completely the opposite of sane...
Ok, makes sense.
But instead of introducing a new "-braille" parameter, maybe we should
rather keep some of the convenience "-usbdevice" possibilities around?
E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but remove
things like "-usbdevice serial" and "-usbdevice host" where the code is
rather ugly and the user do not gain much in comparison to "-device" ?
Thomas
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, (continued)
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Samuel Thibault, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Samuel Thibault, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Samuel Thibault, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Thomas Huth, 2018/01/08
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Thomas Huth, 2018/01/08
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Thomas Huth, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Thomas Huth, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Gerd Hoffmann, 2018/01/09
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Thomas Huth, 2018/01/04
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Markus Armbruster, 2018/01/05
- Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option, Paolo Bonzini, 2018/01/05