Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

[Marc-André Lureau]

Hi

On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake <address@hidden> wrote:
> On 12/15/2017 09:06 AM, Marc-André Lureau wrote:
>>
>> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu
>> specific).
>>
>> Use --quiet to silence make 'is up to date' message.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>>   Makefile  | 2 +-
>>   rules.mak | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>
>
> Tested-by: Eric Blake <address@hidden>
>
> I'd still like a second opinion from another make expert (Paolo?) on whether
> this makes sense.  Thus, even though it looks sane to me, I'm not (yet)
> giving R-b.
>

Paolo, what do you think?

thanks

>>
>> diff --git a/Makefile b/Makefile
>> index 0331c182ed..199f39fde1 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -274,7 +274,7 @@ else
>>   DOCS=
>>   endif
>>   -SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory)
>> BUILD_DIR=$(BUILD_DIR)
>> +SUBDIR_MAKEFLAGS=BUILD_DIR=$(BUILD_DIR)
>>   SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
>>   SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d,
>> $(TARGET_DIRS))
>>   diff --git a/rules.mak b/rules.mak
>> index 6e943335f3..5fb4951561 100644
>> --- a/rules.mak
>> +++ b/rules.mak
>> @@ -131,6 +131,8 @@ modules:
>>   # If called with only a single argument, will print nothing in quiet
>> mode.
>>   quiet-command = $(if $(V),$1,$(if $(2),@printf "  %-7s %s\n" $2 $3 &&
>> $1, @$1))
>>   +MAKEFLAGS += $(if $(V),,--no-print-directory --quiet)
>> +
>>   # cc-option
>>   # Usage: CFLAGS+=$(call cc-option, -falign-functions=0,
>> -malign-functions=0)
>>
>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
>



-- 
Marc-André Lureau