[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/8] target/moxie: Fix tlb_fill
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 2/8] target/moxie: Fix tlb_fill |
Date: |
Fri, 29 Dec 2017 11:31:07 -0800 |
We should not exit unless moxie_cpu_handle_mmu_fault has failed.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/moxie/helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/moxie/helper.c b/target/moxie/helper.c
index 2ecee89f11..6890ffd71c 100644
--- a/target/moxie/helper.c
+++ b/target/moxie/helper.c
@@ -36,9 +36,8 @@ void tlb_fill(CPUState *cs, target_ulong addr, MMUAccessType
access_type,
ret = moxie_cpu_handle_mmu_fault(cs, addr, access_type, mmu_idx);
if (unlikely(ret)) {
- cpu_restore_state(cs, retaddr);
+ cpu_loop_exit_restore(cs, retaddr);
}
- cpu_loop_exit(cs);
}
void helper_raise_exception(CPUMoxieState *env, int ex)
--
2.14.3
- [Qemu-devel] [PULL 0/8] tcg queued patches, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 2/8] target/moxie: Fix tlb_fill,
Richard Henderson <=
- [Qemu-devel] [PULL 1/8] target/*helper: don't check retaddr before calling cpu_restore_state, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 3/8] tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 6/8] tcg: Add tcg_signed_cond, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 8/8] tcg: add cs_base and flags to -d exec output, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 5/8] tcg: Generalize TCGOp parameters, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 7/8] tcg: Allow 6 arguments to TCG helpers, Richard Henderson, 2017/12/29
- [Qemu-devel] [PULL 4/8] tcg: Dynamically allocate TCGOps, Richard Henderson, 2017/12/29
- Re: [Qemu-devel] [PULL 0/8] tcg queued patches, no-reply, 2017/12/29
- Re: [Qemu-devel] [PULL 0/8] tcg queued patches, no-reply, 2017/12/29
- [Qemu-devel] [PULL v2 0/8] tcg queued patches, Richard Henderson, 2017/12/29