[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x8
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32 |
Date: |
Thu, 21 Dec 2017 22:49:10 +0000 |
On 21 December 2017 at 21:11, Laurent Vivier <address@hidden> wrote:
> When compiled with x86_64-w64-mingw32, we have:
>
> error: implicit declaration of function 'qemu_log_mask'
> error: 'LOG_UNIMP' undeclared (first use in this function)
>
> This patch adds the missing include.
>
> Fixes: 7299e1a411
> ("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP")
> Signed-off-by: Laurent Vivier <address@hidden>
Looks to me like it'll be a bug for anything not configured
using the 'log' trace backend, rather than win32 specific.
I'll apply (and fix up the commit message).
thanks
-- PMM