[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/tcg: implement TEST P
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/tcg: implement TEST PROTECTION |
|
Date: |
Thu, 21 Dec 2017 18:17:14 +0100 |
On Tue, 19 Dec 2017 11:32:16 +0100
David Hildenbrand <address@hidden> wrote:
> On 19.12.2017 09:20, Thomas Huth wrote:
> > On 18.12.2017 23:46, David Hildenbrand wrote:
> >> + /*
> >> + * TODO: we currently don't handle all access protection types
> >> + * (including access-list and key-controlled) as well as AR mode.
> >> + */
> >
> > Maybe add some "if (a2 & 0xf0) qemu_log_mask(LOG_UNIMPL, ...)" so that
> > we've got a chance to detect such conditions later?
> >
>
> In general I would agree, however as such acess-list + storage key stuff
> is missing literally all over the place, I don't think it is very helpful.
>
> Once (if ever) we implement it, we will have to go through the whole PoP
> either way and fixup all functions.
The TODO is fine with me.
Out of curiousity, do you already have an idea how much work that would
be? (Not asking for patches right now, mind you :)