[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mu
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed |
Date: |
Thu, 21 Dec 2017 20:57:45 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, 12/19 16:45, Peter Xu wrote:
> Start to use dedicate IO thread for QMP monitors that are not using
> MUXed chardev.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index 0c6403bc65..7183061c2b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -35,6 +35,7 @@
> #include "net/net.h"
> #include "net/slirp.h"
> #include "chardev/char-fe.h"
> +#include "chardev/char-mux.h"
> #include "ui/qemu-spice.h"
> #include "sysemu/numa.h"
> #include "monitor/monitor.h"
> @@ -4522,8 +4523,10 @@ void monitor_init(Chardev *chr, int flags)
> {
> Monitor *mon = g_malloc(sizeof(*mon));
> GMainContext *context;
> + /* Enable IOThread for QMPs that are not using MUX chardev backends. */
> + bool use_io_thr = (!CHARDEV_IS_MUX(chr)) && (flags &
> MONITOR_USE_CONTROL);
>
> - monitor_data_init(mon, false, false);
> + monitor_data_init(mon, false, use_io_thr);
>
> qemu_chr_fe_init(&mon->chr, chr, &error_abort);
> mon->flags = flags;
> --
> 2.14.3
>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, (continued)
- [Qemu-devel] [RFC v6 19/27] qapi: introduce new cmd option "allow-oob", Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 20/27] qmp: export qmp_dispatch_check_obj and allow "id", Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 22/27] qmp: isolate responses into io thread, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2017/12/19
- Re: [Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed,
Fam Zheng <=
- [Qemu-devel] [RFC v6 24/27] qmp: add command "x-oob-test", Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 25/27] docs: update QMP documents for OOB commands, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 26/27] tests: qmp-test: verify command batching, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 27/27] tests: qmp-test: add oob test, Peter Xu, 2017/12/19