Re: [Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

[Gonglei (Arei)]

> -----Original Message-----
> From: Michael S. Tsirkin [mailto:address@hidden
> Sent: Thursday, December 21, 2017 1:39 AM
> To: Gonglei (Arei)
> Cc: address@hidden; address@hidden; Huangweidong (C);
> address@hidden; Zhoujian (jay); address@hidden; longpeng;
> address@hidden; address@hidden
> Subject: Re: [PATCH 0/4] cryptodev: add vhost support
> 
> On Mon, Dec 18, 2017 at 09:03:16AM +0000, Gonglei (Arei) wrote:
> > Ping...
> >
> > Fan (working for DPDK parts) is waiting for those patches upstreamed. :)
> >
> > Thanks,
> > -Gonglei
> 
> As far as I am concerned, the main issue is that it says it assumes
> polling.  virtio does not work like this right now.  As long as spec
> does not support interrupt mode, I don't think we can merge this.
> 
Sorry, Michael. This makes me confused. Because the Qemu part about vhost-user 
crypto 
doesn't do this assumption. The main controversial point is whether session 
operations
should be added in the vhost-user protocol, raised by Paolo. And we made an 
explanation. 

Thanks,
-Gonglei

> >
> > > -----Original Message-----
> > > From: Gonglei (Arei)
> > > Sent: Tuesday, November 28, 2017 5:03 PM
> > > To: address@hidden
> > > Cc: address@hidden; address@hidden; Huangweidong (C);
> > > address@hidden; Zhoujian (jay); address@hidden;
> longpeng;
> > > address@hidden; address@hidden; Gonglei (Arei)
> > > Subject: [PATCH 0/4] cryptodev: add vhost support
> > >
> > > I posted the RFC verion five months ago for DPDK
> > > vhost-crypto implmention, and now it's time to send
> > > the formal version. Because we need an user space scheme
> > > for better performance.
> > >
> > > The vhost user crypto server side patches had been
> > > sent to DPDK community, pls see
> > >
> > > [RFC PATCH 0/6] lib/librte_vhost: introduce new   vhost_user crypto
> backend
> > > support
> > > http://dpdk.org/ml/archives/dev/2017-November/081048.html
> > >
> > > You also can get virtio-crypto polling mode driver from:
> > >
> > > [PATCH] virtio: add new driver for crypto devices
> > > http://dpdk.org/ml/archives/dev/2017-November/081985.html
> > >
> > >
> > > Gonglei (4):
> > >   cryptodev: add vhost-user as a new cryptodev backend
> > >   cryptodev: add vhost support
> > >   cryptodev-vhost-user: add crypto session handler
> > >   cryptodev-vhost-user: set the key length
> > >
> > >  backends/Makefile.objs                |   4 +
> > >  backends/cryptodev-builtin.c          |   1 +
> > >  backends/cryptodev-vhost-user.c       | 381
> > > ++++++++++++++++++++++++++++++++++
> > >  backends/cryptodev-vhost.c            | 297
> > > ++++++++++++++++++++++++++
> > >  docs/interop/vhost-user.txt           |  19 ++
> > >  hw/virtio/vhost-user.c                |  89 ++++++++
> > >  hw/virtio/virtio-crypto.c             |  70 +++++++
> > >  include/hw/virtio/vhost-backend.h     |   8 +
> > >  include/hw/virtio/virtio-crypto.h     |   1 +
> > >  include/sysemu/cryptodev-vhost-user.h |  47 +++++
> > >  include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
> > >  include/sysemu/cryptodev.h            |   8 +
> > >  qemu-options.hx                       |  21 ++
> > >  vl.c                                  |   4 +
> > >  14 files changed, 1104 insertions(+)
> > >  create mode 100644 backends/cryptodev-vhost-user.c
> > >  create mode 100644 backends/cryptodev-vhost.c
> > >  create mode 100644 include/sysemu/cryptodev-vhost-user.h
> > >  create mode 100644 include/sysemu/cryptodev-vhost.h
> > >
> > > --
> > > 1.8.3.1
> > >