[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/14] block: Don't wait for requests in bdrv_drain*_
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 08/14] block: Don't wait for requests in bdrv_drain*_end() |
Date: |
Wed, 20 Dec 2017 14:19:33 +0100 |
The device is drained, so there is no point in waiting for requests at
the end of the drained section. Remove the bdrv_drain_recurse() calls
there.
The bdrv_drain_recurse() calls were introduced in commit 481cad48e5e
in order to call the .bdrv_co_drain_end() driver callback. This is now
done by a separate bdrv_drain_invoke() call.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
block/io.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 390d463c71..5fdb92a15e 100644
--- a/block/io.c
+++ b/block/io.c
@@ -299,7 +299,6 @@ void bdrv_drained_end(BlockDriverState *bs)
bdrv_parent_drained_end(bs);
bdrv_drain_invoke(bs, false);
- bdrv_drain_recurse(bs);
aio_enable_external(bdrv_get_aio_context(bs));
}
@@ -400,7 +399,6 @@ void bdrv_drain_all_end(void)
aio_enable_external(aio_context);
bdrv_parent_drained_end(bs);
bdrv_drain_invoke(bs, false);
- bdrv_drain_recurse(bs);
aio_context_release(aio_context);
}
--
2.13.6
- [Qemu-devel] [PULL 00/14] Block layer patches, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 01/14] hw/block/nvme: Convert to realize, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 02/14] block: Formats don't need CONSISTENT_READ with NO_IO, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 03/14] iotests: fix 197 for vpc, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 04/14] block: Make bdrv_drain_invoke() recursive, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 05/14] block: Call .drain_begin only once in bdrv_drain_all_begin(), Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 06/14] test-bdrv-drain: Test BlockDriver callbacks for drain, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 07/14] block: bdrv_drain_recurse(): Remove unused begin parameter, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 08/14] block: Don't wait for requests in bdrv_drain*_end(),
Kevin Wolf <=
- [Qemu-devel] [PULL 09/14] block: Unify order in drain functions, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 12/14] qcow2: get rid of qcow2_backing_read1 routine, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 11/14] block: Don't acquire AioContext in hmp_qemu_io(), Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 10/14] qemu-img: Document --force-share / -U, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 13/14] block: Document that x-blockdev-change breaks quorum children list, Kevin Wolf, 2017/12/20
- [Qemu-devel] [PULL 14/14] nvme: Add tracing, Kevin Wolf, 2017/12/20
- Re: [Qemu-devel] [PULL 00/14] Block layer patches, Peter Maydell, 2017/12/20