|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable |
Date: | Tue, 19 Dec 2017 10:31:18 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/19/2017 09:45 AM, Marc-André Lureau wrote:
+Useful make targets +=================== + +- help + + Print a help message for the most common build targets.Except that this patch forgot to tweak 'make help' to mention 'make print-VAR' ;)Well, I don't think print-VAR is a common build target, it's a build-sys hack/debug imho, so having it described in build-system.txt only make sense. Do you agree?
With the bash-completion library installed, performing tab-completion on 'make ' produces a large list of targets, which includes 'help', but even with your patch does NOT include 'print-CFLAGS' or any variant of print-. If I use just tab-completion and 'make help', then having 'print-FOO' listed under the "Generic targets:" section of the help output would let me discover it without me having to read build-system.txt.
Does anyone else have a strong opinion for or against the additional output in 'make help'?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |