[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm |
|
Date: |
Mon, 18 Dec 2017 13:35:38 +0100 |
On Mon, 18 Dec 2017 13:27:09 +0100
Paolo Bonzini <address@hidden> wrote:
> On 18/12/2017 13:16, Cornelia Huck wrote:
> > Building with --disable-tpm yields
> >
> > ../hw/core/qdev-properties-system.o: In function `set_tpm':
> > /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined
> > reference to `qemu_find_tpm_be'
> > /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:278: undefined
> > reference to `tpm_backend_init'
> > ../hw/core/qdev-properties-system.o: In function `release_tpm':
> > /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:291: undefined
> > reference to `tpm_backend_reset'
> >
> > Add some proper stubs for those functions.
> >
> > Fixes: 493b78303532 ("qdev: add DEFINE_PROP_TPMBE")
> > Reported-by: Thomas Huth <address@hidden>
> > Signed-off-by: Cornelia Huck <address@hidden>
>
> Maybe all the new code can be moved from qdev-properties-system.c to
> hw/tpm/qdev.c instead? (Adding stubs should be the last resort,
> especially if the stubs are never used outside system emulation).
Probably hw/tpm/tpm-tis.c?