Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test

[Peter Xu]

On Thu, Dec 14, 2017 at 02:47:12PM +0000, Stefan Hajnoczi wrote:
> On Tue, Dec 05, 2017 at 01:52:00PM +0800, Peter Xu wrote:
> > +    /* Try a fake capability, it should fail. */
> > +    resp = qmp("{ 'execute': 'qmp_capabilities', "
> > +               "  'arguments': { 'enable': [ 'cap-does-not-exist' ] } }");
> > +    g_assert(qdict_haskey(resp, "error"));
> 
> Missing QDECREF(resp) here and throughout the rest of the function.

I believe I missed four QDECREF()s.

> 
> Besides that:
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Hope my counting is correct, then I'll add the r-b.  Thanks!

-- 
Peter Xu