[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN a
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842) |
Date: |
Mon, 18 Dec 2017 09:05:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
>> Or we could suppress the s390x compiler warning by using a compiler
>> pragma. But I don't like that alternative.
>
> I think the best solution would be to call tcg_s390_program_interrupt()
> directly from helper_divs64() instead of going through the
> s390_program_interrupt() wrapper. helper_divs64() is for TCG only, so it
> should be fine to directly use the tcg_s390_program_interrupt() function
> there.
If there is not a good reason, I'd prefer to have only one function for
injecting program interrupts. (adding 3 return statements looks IMHO
nicer).
>
> Thomas
>
--
Thanks,
David / dhildenb
Re: [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842), no-reply, 2017/12/20