[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3 08/13] opencores_eth: use inline net_crc32() and b
From: |
Mark Cave-Ayland |
Subject: |
[Qemu-devel] [PATCHv3 08/13] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx() |
Date: |
Fri, 15 Dec 2017 18:41:50 +0000 |
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.
Signed-off-by: Mark Cave-Ayland <address@hidden>
---
hw/net/opencores_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c
index 268d6a7892..d42b79c08c 100644
--- a/hw/net/opencores_eth.c
+++ b/hw/net/opencores_eth.c
@@ -36,6 +36,7 @@
#include "hw/net/mii.h"
#include "hw/sysbus.h"
#include "net/net.h"
+#include "net/eth.h"
#include "sysemu/sysemu.h"
#include "trace.h"
@@ -373,7 +374,7 @@ static ssize_t open_eth_receive(NetClientState *nc,
if (memcmp(buf, bcast_addr, sizeof(bcast_addr)) == 0) {
miss = GET_REGBIT(s, MODER, BRO);
} else if ((buf[0] & 0x1) || GET_REGBIT(s, MODER, IAM)) {
- unsigned mcast_idx = compute_mcast_idx(buf);
+ unsigned mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
miss = !(s->regs[HASH0 + mcast_idx / 32] &
(1 << (mcast_idx % 32)));
trace_open_eth_receive_mcast(
--
2.11.0
- [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 06/13] sungem: fix multicast filter CRC calculation, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 02/13] net: introduce net_crc32_le() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 01/13] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 09/13] lan9118: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 08/13] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx(),
Mark Cave-Ayland <=
- [Qemu-devel] [PATCHv3 07/13] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 03/13] pcnet: switch pcnet over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 04/13] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 05/13] sunhme: switch sunhme over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 12/13] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 10/13] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 13/13] net: remove unused compute_mcast_idx() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 11/13] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- Re: [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions, Jason Wang, 2017/12/20