qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help


From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
Date: Fri, 15 Dec 2017 15:47:40 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 26/10/17 12:41, Alexey Kardashevskiy wrote:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
> 
> Also, since only lower case letters are specified in qapi/common.json,
> this changes the letter cases too.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

ping?


> ---
> 
> address@hidden:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep 
> kernel-irqchip
> 
> Was:
> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
> 
> Now:
> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 36c2fb069c..bd3db14e12 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void 
> *data)
>      object_class_property_set_description(oc, "accel",
>          "Accelerator list", &error_abort);
>  
> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>          NULL, machine_set_kernel_irqchip,
>          NULL, NULL, &error_abort);
>      object_class_property_set_description(oc, "kernel-irqchip",
> 


-- 
Alexey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]