[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API |
Date: |
Thu, 14 Dec 2017 21:38:17 -0300 |
> This is rewritten later, why bother setting this here?
>
>>
>>
>> - dma_memory_read(&address_space_memory, entry_addr + 2,
>> - (uint8_t *)(&dscr->length), 2);
>> - dscr->length = le16_to_cpu(dscr->length);
>> + dscr->length = lduw_le_dma(&address_space_memory, entry_addr + 2);
>>
>>
>> - dma_memory_read(&address_space_memory, entry_addr + 4,
>> - (uint8_t *)(&dscr->addr), 8);
>
> What about dscr->addr which is set here?
Oops. I'll drop this patch.
>> - dscr->attr = le64_to_cpu(dscr->attr);
>> + dscr->attr = ldq_le_dma(&address_space_memory, entry_addr + 4);
>>
>> The API is detailled in this file: docs/devel/loads-stores.rst
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), (continued)
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Alistair Francis, 2017/12/14
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Philippe Mathieu-Daudé, 2017/12/14
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Alistair Francis, 2017/12/14
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Philippe Mathieu-Daudé, 2017/12/14
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Alistair Francis, 2017/12/14
- Re: [Qemu-devel] [PATCH 04/14] sdhci: use deposit64(), Philippe Mathieu-Daudé, 2017/12/14
[Qemu-devel] [PATCH 03/14] sdhci: use the ldst_le_dma() API, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 05/14] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h", Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 07/14] sdhci: refactor common sysbus/pci realize() into sdhci_realizefn(), Philippe Mathieu-Daudé, 2017/12/13