[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl |
Date: |
Thu, 14 Dec 2017 18:41:57 +0100 |
On Mon, 11 Dec 2017 17:19:17 -0500
"Collin L. Walling" <address@hidden> wrote:
> ECKD DASDs have different IPL structures for CDL and LDL
> formats. The current Ipl1 and Ipl2 structs follow the CDL
> format, so we prepend "EckdCdl" to them. Boot info for LDL
> has been moved to a new struct: EckdLdlIpl1.
>
> Also introduce structs for IPL stages 1 and 1b and for
> disk geometry.
>
> Signed-off-by: Collin L. Walling <address@hidden>
> Acked-by: Janosch Frank <address@hidden>
> ---
> pc-bios/s390-ccw/bootmap.c | 24 ++++++++++----------
> pc-bios/s390-ccw/bootmap.h | 55
> +++++++++++++++++++++++++++++++++-------------
> 2 files changed, 53 insertions(+), 26 deletions(-)
>
> + mbr_block_nr =
> + eckd_block_num((void *)&(ipl1->boot_info.bp.ipl.bm_ptr.eckd.bptr));
Let me nominate this as "crazy nested struct of the week".
(Just kidding, your patch certainly improves things in general :)
> +typedef struct EckdSeekarg {
> + uint16_t pad;
> + uint16_t cyl;
> + uint16_t head;
> + uint8_t sec;
> + uint8_t pad2;
> +} __attribute__ ((packed)) EckdSeekarg;
Maybe make this EckdSeekArg?
- [Qemu-devel] [PATCH v2 0/5] Interactive Boot Menu for DASD and SCSI Guests on s390x, Collin L. Walling, 2017/12/11
- [Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl, Collin L. Walling, 2017/12/11
- Re: [Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl,
Cornelia Huck <=
- [Qemu-devel] [PATCH v2 1/5] s390-ccw: update libc, Collin L. Walling, 2017/12/11
- Re: [Qemu-devel] [PATCH v2 1/5] s390-ccw: update libc, Thomas Huth, 2017/12/18
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc, Collin L. Walling, 2017/12/18
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc, Thomas Huth, 2017/12/19
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc, Collin L. Walling, 2017/12/19
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc, Collin L. Walling, 2017/12/19
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc, Thomas Huth, 2017/12/20
[Qemu-devel] [PATCH v2 3/5] s390-ccw: parse and set boot menu options, Collin L. Walling, 2017/12/11