[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1 |
|
Date: |
Tue, 12 Dec 2017 15:11:05 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 11/12/2017 15:51, Samuel Thibault wrote:
>> Is magic clamping desirable, or is it better to make it a hard error if
>> the user configured a size that is not possible?
> The thing is: the user didn't configure something, she just happened to
> use a braille device bigger than 84 to display qemu's braille output.
Makes sense, I clarified the commit message to
Baum device bigger than 84 do not actually exist, but the user's own
Braille device might be wider than 84 columns. Some guest drivers
would be upset by such sizes, so clamp the device size.
Thanks,
Paolo