[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate |
Date: |
Tue, 12 Dec 2017 12:28:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/12/2017 12:03, Dr. David Alan Gilbert wrote:
>> nop means that attributes (readonly, romd_mode, mr+offset_in_region)
>> haven't changed; nop is optionally followed by log_start or log_stop.
>> If any of them changes, you get del+add (del is always before add).
>>
>>> Th nice thing we have here is we get a full walk of the physical memory
>>> in order; keeping it in order makes our data structure easy for merging.
>> That's the same that you get with region_del/add.
> Hmm it would be good if that was documented somewhere.
> I thought you'd only get an _add/_del and then a commit.
>
> However, what do I do in vhost_dev_start? At the moment I'm forcfully
> regenerating it using the same code.
When you add a listener, you get adds and a commit for the current state
of the AddressSpace.
Paolo
[Qemu-devel] [PATCH v3 2/8] vhost: Move log_dirty check, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 3/8] vhost: Simplify ring verification checks, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 7/8] vhost: Remove old vhost_set_memory etc, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 6/8] vhost: Compare and copy updated region data into device state, Dr. David Alan Gilbert (git), 2017/12/11
[Qemu-devel] [PATCH v3 8/8] vhost: Move mem_sections maintenance into commit/update routines, Dr. David Alan Gilbert (git), 2017/12/11