[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block/iscsi: dont leave allocmap in an inva
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block/iscsi: dont leave allocmap in an invalid state on UNMAP failure |
Date: |
Fri, 8 Dec 2017 09:07:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 12/08/2017 05:51 AM, Peter Lieven wrote:
> we forgot to set the allocmap to invalid if an UNMAP call fails.
>
> Cc: address@hidden
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/iscsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> @@ -1128,6 +1128,9 @@ retry:
> goto retry;
> }
>
> + iscsi_allocmap_set_invalid(iscsilun, offset >> BDRV_SECTOR_BITS,
> + bytes >> BDRV_SECTOR_BITS);
> +
Semantic conflict with my pending patches to convert the allocmap to
byte-based:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01253.html
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature