Re: [Qemu-devel] [PATCH v5 23/23] sev: add migration blocker

[Brijesh Singh]

On 12/07/2017 05:03 AM, Dr. David Alan Gilbert wrote:
.......

> >   
> >   #define SEV_FW_MAX_ERROR      0x17
> >   
> > @@ -460,6 +462,7 @@ static void
> >   sev_launch_finish(SEVState *s)
> >   {
> >       int ret, error;
> > +    Error *local_err = NULL;
> >   
> >       ret = sev_ioctl(KVM_SEV_LAUNCH_FINISH, 0, &error);
> >       if (ret) {
> > @@ -470,6 +473,16 @@ sev_launch_finish(SEVState *s)
> >   
> >       s->cur_state = SEV_STATE_RUNNING;
> >       DPRINTF("SEV: LAUNCH_FINISH\n");
>
> (from a previous patch)
> Please use the tracing facility rather than new DPRINTF's
> if possible - if you've not used it before, then
> --enable-trace-backends=log   is the easy way to get going
> and you can turn on and off the stuff you're interested in
> tracing at run time without having to rebuild.


Thanks for review, I will look into converting those DPRINTF's in trace 
logging.