[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: add 202 external snapshots
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: add 202 external snapshots IOThread test |
Date: |
Thu, 7 Dec 2017 15:58:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 12/06/2017 08:45 AM, Stefan Hajnoczi wrote:
> QMP 'transaction' blockdev-snapshot-sync with multiple disks in an
> IOThread is an untested code path. Several bugs have been found in
> connection with this command. This patch adds a test case to prevent
> future regressions.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/202 | 95
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/202.out | 11 ++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 107 insertions(+)
> create mode 100755 tests/qemu-iotests/202
> create mode 100644 tests/qemu-iotests/202.out
>
> +# Creator/Owner: Stefan Hajnoczi <address@hidden>
There's another cleanup series posted that drops these sorts of lines in
favor of git history.
> +++ b/tests/qemu-iotests/202.out
> @@ -0,0 +1,11 @@
> +Launching VM...
> +Adding IOThread...
> +{u'return': {}}
> +Adding blockdevs...
> +{u'return': {}}
> +{u'return': {}}
> +Setting iothread...
> +{u'return': {}}
> +{u'return': {}}
> +Creating external snapshots...
> +{u'return': {}}
Yay - a python test with sane output - if I had to, I could actually
debug this test without too much effort!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 4/9] block: don't keep AioContext acquired after blockdev_backup_prepare(), (continued)
- [Qemu-devel] [PATCH v2 5/9] block: don't keep AioContext acquired after internal_snapshot_prepare(), Stefan Hajnoczi, 2017/12/06
- [Qemu-devel] [PATCH v2 6/9] block: drop unused BlockDirtyBitmapState->aio_context field, Stefan Hajnoczi, 2017/12/06
- [Qemu-devel] [PATCH v2 7/9] iothread: add iothread_by_id() API, Stefan Hajnoczi, 2017/12/06
- [Qemu-devel] [PATCH v2 8/9] blockdev: add x-blockdev-set-iothread testing command, Stefan Hajnoczi, 2017/12/06
- [Qemu-devel] [PATCH v2 9/9] qemu-iotests: add 202 external snapshots IOThread test, Stefan Hajnoczi, 2017/12/06
- Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: add 202 external snapshots IOThread test,
Eric Blake <=
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/9] blockdev: fix QMP 'transaction' with IOThreads, Stefan Hajnoczi, 2017/12/08
- Re: [Qemu-devel] [PATCH v2 0/9] blockdev: fix QMP 'transaction' with IOThreads, Kevin Wolf, 2017/12/08
- Re: [Qemu-devel] [PATCH v2 0/9] blockdev: fix QMP 'transaction' with IOThreads, Stefan Hajnoczi, 2017/12/08
- Re: [Qemu-devel] [PATCH v2 0/9] blockdev: fix QMP 'transaction' with IOThreads, Paolo Bonzini, 2017/12/13