Re: [Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

[Corey Minyard]

On 11/27/2017 04:06 AM, Roman Kagan wrote:
> On Fri, Nov 24, 2017 at 08:36:53PM -0600, Corey Minyard wrote:
> > On 11/24/2017 09:36 AM, Roman Kagan wrote:
snip
> > > +
> > > +const PropertyInfo qdev_prop_uuid = {
> > > +    .name  = "str",
> > > +    .description = "UUID (aka GUID) or \"auto\" for random value",
> > > +    .get   = get_uuid,
> > > +    .set   = set_uuid,
> > There is a UUID value you can use as a default in  vl.c, named qemu_uuid.
> > Just in case you want to set a default value here.
> I'm not sure what a common non-null default for all uuid properties
> would mean...

It depends on what the uuid is for.  If you are trying to uniquely 
identify devices to
QEMU or the OS, then it make no sense.  If you are trying to identify 
qemu or what
is running in it to outside entities, then it might make sense.  I 
didn't know the
purpose of this uuid, so I thought I would suggest.

-corey

> IMO most of the time it makes sense to default to "auto".  I'll have a
> look if I can do it within this patch.
>
> Thanks,
> Roman.