[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] target/sh4/translate.c: fix TCG leak during
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [RFC PATCH] target/sh4/translate.c: fix TCG leak during gusa sequence |
Date: |
Wed, 6 Dec 2017 23:33:27 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On 2017-12-06 09:30, Alex Bennée wrote:
> This fixes bug #1735384 while running java under qemu-sh4. When debug
> was enabled it showed a problem with TCG temps. Once fixed I was able
> to run java -version normally.
>
> Reported-by: John Paul Adrian Glaubitz <address@hidden>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> target/sh4/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index 703020fe87..b4b5c822d0 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -2189,7 +2189,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State
> *env, int *pmax_insns)
> }
>
> /* If op_src is not a valid register, then op_arg was a constant. */
> - if (op_src < 0) {
> + if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) {
> tcg_temp_free_i32(op_arg);
> }
I guess this happens when trying to match the exchange pattern, so this
looks correct to me.
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net