Re: [Qemu-devel] [PATCH] Remove MemoryRegionSection check code from sparc_cpu_get_phys_page_debug()

[Mark Cave-Ayland]

On 27/11/17 20:19, Jean-Christophe DUBOIS wrote:

> Hello Mark,
>
> Did you get any second opinion on this?
>
> Also do you need me to resend the patch with the SPARC keyword in the 
> patch subject line?

Hi Jean-Christophe,

Apologies for the delay as I've been fairly busy with my day job. I 
believe Artyom is away at the moment which is why I haven't written a 
reply, but AFAICT there are 2 options:

1) Remove the MemoryRegion check (as per your patch)

2) Change dump_mmu() to call cpu_sparc_get_phys_page() directly

I'm mildly leaning towards 1) since there doesn't seem to be equivalent 
code in other architectures, however the tree is currently in freeze for 
the upcoming 2.11 release so that's where most people's free time is 
currently being spent.

Once I can confirm the correct approach, I'm keen to get this into the 
2.12 tree early so there is plenty of time to spot any regressions 
during the next development cycle.


ATB,

Mark.