Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

[Eric Blake]

On 12/01/2017 06:57 AM, Juan Quintela wrote:
> It will be used to store the uri tcp_port parameter.  This is the only
> parameter than can change and we can need to be able to connect to it.
>
> Signed-off-by: Juan Quintela <address@hidden>
>
> --

> @@ -2422,6 +2430,8 @@ static Property migration_properties[] = {
>       DEFINE_PROP_SIZE("xbzrle-cache-size", MigrationState,
>                         parameters.xbzrle_cache_size,
>                         DEFAULT_MIGRATE_XBZRLE_CACHE_SIZE),
> +    DEFINE_PROP_UINT16("x-tcp-port", MigrationState,
> +                       parameters.tcp_port, 0),

Why is this one experimental when others are not,

>   
>       /* Migration capabilities */
>       DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE),
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 4cd3d13158..e2a1d86216 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -488,6 +488,9 @@
>   #                     and a power of 2
>   #                     (Since 2.11)
>   #
> +# @tcp-port: Only used for tcp, to know what is the real port

s/what is the real port/what the real port is/

> +#                     (Since 2.12)
> +#

Especially since it is not experimental here?

> @@ -564,6 +567,10 @@
>   #                     needs to be a multiple of the target page size
>   #                     and a power of 2
>   #                     (Since 2.11)
> +#
> +# @tcp-port: Only used for tcp, to know what is the real port

same wording tweak

> +#                     (Since 2.12)
> +#
>   # Since: 2.4
>   ##
>   # TODO either fuse back into MigrationParameters, or make
> @@ -582,7 +589,8 @@
>               '*block-incremental': 'bool',
>               '*x-multifd-channels': 'int',
>               '*x-multifd-page-count': 'int',
> -            '*xbzrle-cache-size': 'size' } }
> +            '*xbzrle-cache-size': 'size' ,

the space before comma looks unusual (although it's harmless)

> +            '*tcp-port': 'uint16'} }


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org