[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root()
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root() |
Date: |
Thu, 30 Nov 2017 14:23:45 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Nov 29, 2017 at 07:46:25PM +1100, David Gibson wrote:
[...]
> struct PCIBus {
> BusState qbus;
> + enum PCIBusFlags flags;
> PCIIOMMUFunc iommu_fn;
> void *iommu_opaque;
> uint8_t devfn_min;
> @@ -440,8 +446,12 @@ struct PCIBus {
> Notifier machine_done;
> };
I would prefer directly defining flags as uint64_t then it's more
clear that it's a bitmask (enum let me think of only one flag will be
set, but I may be wrong), but it's fine too to me.
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu
[Qemu-devel] [for-2.12 2/7] pci: Move bridge data structures from pci_bus.h to pci_bridge.h, David Gibson, 2017/11/29
[Qemu-devel] [for-2.12 5/7] pci: Add pci_dev_bus_num() helper, David Gibson, 2017/11/29