[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/10] blockjob: Remove the job from the list earlier
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 05/10] blockjob: Remove the job from the list earlier in block_job_unref() |
Date: |
Wed, 29 Nov 2017 16:26:23 +0100 |
From: Alberto Garcia <address@hidden>
When destroying a block job in block_job_unref() we should remove it
from the job list before calling block_job_remove_all_bdrv().
This is because removing the BDSs can trigger an aio_poll() and wake
up other jobs that might attempt to use the block job list. If that
happens the job we're currently destroying should not be in that list
anymore.
Signed-off-by: Alberto Garcia <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index ff9a614531..2f0cc1528b 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -152,6 +152,7 @@ void block_job_unref(BlockJob *job)
{
if (--job->refcnt == 0) {
BlockDriverState *bs = blk_bs(job->blk);
+ QLIST_REMOVE(job, job_list);
bs->job = NULL;
block_job_remove_all_bdrv(job);
blk_remove_aio_context_notifier(job->blk,
@@ -160,7 +161,6 @@ void block_job_unref(BlockJob *job)
blk_unref(job->blk);
error_free(job->blocker);
g_free(job->id);
- QLIST_REMOVE(job, job_list);
g_free(job);
}
}
--
2.13.6
- [Qemu-devel] [PULL 00/10] Block layer fixes for 2.11.0-rc3, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 01/10] iotests: fix 075 and 078, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 03/10] qemu-options: Mention locking option of file driver, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 04/10] QAPI & interop: Clarify events emitted by 'block-job-cancel', Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 02/10] docs: Add image locking subsection, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 05/10] blockjob: Remove the job from the list earlier in block_job_unref(),
Kevin Wolf <=
- [Qemu-devel] [PULL 06/10] block: Expect graph changes in bdrv_parent_drained_begin/end, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 07/10] blockjob: remove clock argument from block_job_sleep_ns, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 08/10] blockjob: introduce block_job_do_yield, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 09/10] blockjob: reimplement block_job_sleep_ns to allow cancellation, Kevin Wolf, 2017/11/29
- [Qemu-devel] [PULL 10/10] block/nfs: fix nfs_client_open for filesize greater than 1TB, Kevin Wolf, 2017/11/29
- Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.11.0-rc3, Peter Maydell, 2017/11/29