[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/5] s390-ccw: ipl structs for e
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl |
Date: |
Tue, 28 Nov 2017 17:41:57 +0100 |
On Tue, 28 Nov 2017 10:42:30 -0500
"Collin L. Walling" <address@hidden> wrote:
> On 11/28/2017 05:48 AM, Cornelia Huck wrote:
> > On Mon, 27 Nov 2017 15:55:33 -0500
> > "Collin L. Walling" <address@hidden> wrote:
> >
> >> ECKD DASDs have different IPL structures for CDL and LDL
> >> formats. The current Ipl1 and Ipl2 structs follow the CDL
> >> format, so we prepend "EckdCdl" to them. A new struct,
> >> EckdLdlIpl1 is introduced and contains boot info for LDL.
> > So does this add support for LDL DASD, or does it simply enhance the
> > code? It's unclear from the desription alone.
>
> Enhances. I'll reword it. Perhaps something along the lines of "Boot info
> for LDL has been *moved* to a new struct, EckdLdlIpl1"
Yes, sounds good.
>
> >
> >> Also introduce structs for IPL stages 1 and 1b and for
> >> disk geometry.
> >>
> >> Signed-off-by: Collin L. Walling <address@hidden>
> >> Acked-by: Janosch Frank <address@hidden>
> >> ---
> >> pc-bios/s390-ccw/bootmap.c | 24 ++++++++++----------
> >> pc-bios/s390-ccw/bootmap.h | 55
> >> +++++++++++++++++++++++++++++++++-------------
> >> 2 files changed, 53 insertions(+), 26 deletions(-)
>
>