Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

[Gonglei (Arei)]

> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden
> Sent: Tuesday, November 28, 2017 6:02 PM
> To: Gonglei (Arei); address@hidden
> Cc: address@hidden; Huangweidong (C); address@hidden; Zhoujian
> (jay); address@hidden; longpeng; address@hidden;
> address@hidden
> Subject: Re: [PATCH 3/4] cryptodev-vhost-user: add crypto session handler
> 
> On 28/11/2017 10:03, Gonglei wrote:
> > Introduce two vhost-user meassges:
> VHOST_USER_CREATE_CRYPTO_SESSION
> > and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side
> > support crypto operation in cryptodev host-user backend.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > Signed-off-by: Longpeng(Mike) <address@hidden>
> > Signed-off-by: Zhoujian <address@hidden>
> > ---
> >  backends/cryptodev-vhost-user.c   | 50 +++++++++++++++++-----
> >  docs/interop/vhost-user.txt       | 19 +++++++++
> >  hw/virtio/vhost-user.c            | 89
> +++++++++++++++++++++++++++++++++++++++
> >  include/hw/virtio/vhost-backend.h |  8 ++++
> >  4 files changed, 155 insertions(+), 11 deletions(-)
> 
> As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as
> a result of sending a message on the control virtqueue.
> 
VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is a message type of control queue,
Means creating a session for next crypto requests.

> Why can't vhost-user also process create/destroy session messages on the
> control virtqueue, instead of having device-specific messages in the
> protocol?
> 
You mean we can share control virtqueue to DPDK as well? Like data queues?

Maybe I don't get your point. :(

Thanks,
-Gonglei