[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to tra
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen |
Date: |
Wed, 22 Nov 2017 13:22:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/server.c | 34 ++++++++++++++++++++++------------
> 1 file changed, 22 insertions(+), 12 deletions(-)
> @@ -299,7 +312,7 @@ static int nbd_negotiate_handle_export_name(NBDClient
> *client,
> error_setg(errp, "Bad length received");
> return -EINVAL;
> }
> - if (nbd_read(client->ioc, name, client->optlen, errp) < 0) {
> + if (nbd_opt_read(client, name, client->optlen, errp) < 0) {
> error_prepend(errp, "read failed: ");
> return -EINVAL;
> }
More context:
name[client->optlen] = '\0';
Oops - that's broken, because client->optlen is now 0. Which means your
code was only tested with empty-string default exports.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid, (continued)
- [Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid, Vladimir Sementsov-Ogievskiy, 2017/11/22
- [Qemu-devel] [PATCH 5/5] nbd/server: structurize option reply sending, Vladimir Sementsov-Ogievskiy, 2017/11/22
- [Qemu-devel] [PATCH 4/5] nbd: rename nbd_option and nbd_opt_reply, Vladimir Sementsov-Ogievskiy, 2017/11/22
- [Qemu-devel] [PATCH 1/5] nbd/server: refactor negotiation functions parameters, Vladimir Sementsov-Ogievskiy, 2017/11/22
- [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen, Vladimir Sementsov-Ogievskiy, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/5] NBD server refactoring before BLOCK_STATUS, no-reply, 2017/11/22