[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside t
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside the BARs |
Date: |
Tue, 21 Nov 2017 11:51:04 +0100 |
On Thu, 16 Nov 2017 18:51:55 +0100
Pierre Morel <address@hidden> wrote:
> When dispatching memory access to PCI BAR region, we must
> look for possible subregions, used by the PCI device to map
> different memory areas inside the same PCI BAR.
>
> Since the data offset we received is calculated starting at the
> region start address we need to adjust the offset for the subregion.
>
> The data offset inside the subregion is calculated by substracting
> the subregion's starting address from the data offset in the region.
>
> The access to the MSIX region is now handled in a generic way,
> we do not need the specific trap_msix() function anymore.
>
> Signed-off-by: Pierre Morel <address@hidden>
> Reviewed-by: Yi Min Zhao <address@hidden>
> ---
> hw/s390x/s390-pci-inst.c | 44 +++++++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 19 deletions(-)
This one also looks fine.
- [Qemu-devel] [PATCH v2 0/7] s390x/pci: Improve zPCI to cover more cases, Pierre Morel, 2017/11/16
- [Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside the BARs, Pierre Morel, 2017/11/16
- Re: [Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside the BARs,
Cornelia Huck <=
- [Qemu-devel] [PATCH v2 3/7] s390x/pci: rework PCI LOAD, Pierre Morel, 2017/11/16
- [Qemu-devel] [PATCH v2 5/7] s390x/pci: move the memory region read from pcilg, Pierre Morel, 2017/11/16
- [Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion, Pierre Morel, 2017/11/16
- [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK, Pierre Morel, 2017/11/16