[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] hw/net/eepro100: Fix endianness problem on big e
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 3/6] hw/net/eepro100: Fix endianness problem on big endian hosts |
Date: |
Mon, 20 Nov 2017 11:31:24 +0800 |
From: Thomas Huth <address@hidden>
Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission
mode"), the test/pxe-test is broken for the eepro100 device on big
endian hosts. However, it seems like that commit did not introduce the
problem, but just uncovered it: The EEPRO100State->tx.tbd_array_addr and
EEPRO100State->tx.tcb_bytes fields are already in host byte order, since
they have already been byte-swapped in the read_cb() function.
Thus byte-swapping them in tx_command() again results in the wrong
endianness. Removing the byte-swapping here fixes the pxe-test.
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/eepro100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index 91dd058..1c0def5 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -754,8 +754,8 @@ static void read_cb(EEPRO100State *s)
static void tx_command(EEPRO100State *s)
{
- uint32_t tbd_array = le32_to_cpu(s->tx.tbd_array_addr);
- uint16_t tcb_bytes = (le16_to_cpu(s->tx.tcb_bytes) & 0x3fff);
+ uint32_t tbd_array = s->tx.tbd_array_addr;
+ uint16_t tcb_bytes = s->tx.tcb_bytes & 0x3fff;
/* Sends larger than MAX_ETH_FRAME_SIZE are allowed, up to 2600 bytes. */
uint8_t buf[2600];
uint16_t size = 0;
--
2.7.4
- [Qemu-devel] [PULL 0/6] Net patches, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 1/6] colo-compare: fix the dangerous assignment, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 2/6] Revert "Add new PCI ID for i82559a", Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 4/6] MAINTAINERS: Add missing entry for eepro100 emulation, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 5/6] net: Transmit zero UDP checksum as 0xFFFF, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 3/6] hw/net/eepro100: Fix endianness problem on big endian hosts,
Jason Wang <=
- [Qemu-devel] [PULL 6/6] hw/net/vmxnet3: Fix code to work on big endian hosts, too, Jason Wang, 2017/11/19
- Re: [Qemu-devel] [PULL 0/6] Net patches, no-reply, 2017/11/19
- Re: [Qemu-devel] [PULL 0/6] Net patches, Peter Maydell, 2017/11/20