Re: [Qemu-devel] [PATCH for-2.11] tests/bios-tables-test: Fix endianess problems when passing data to iasl

[Thomas Huth]

On 16.11.2017 11:54, Daniel P. Berrange wrote:
> On Thu, Nov 16, 2017 at 09:55:46AM +0100, Thomas Huth wrote:
>> The bios-tables-test was writing out files that we pass to iasl in
>> with the wrong endianness in the header when running on a big endian
>> host. So instead of storing mixed endian information in our structures,
>> let's keep everything in little endian and byte-swap it only when we
>> need a value in the code.
>>
>> Reported-by: Daniel P. Berrange <address@hidden>
>> Buglink: https://bugs.launchpad.net/qemu/+bug/1724570
>> Suggested-by: Michael S. Tsirkin <address@hidden>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  tests/acpi-utils.h       | 27 +++++----------------------
>>  tests/bios-tables-test.c | 42 ++++++++++++++++++++++--------------------
>>  2 files changed, 27 insertions(+), 42 deletions(-)
> 
> This fixes bios-tables-test, but has broken vmgenid-tgst
> 
> TEST: tests/vmgenid-test... (pid=8197)
>   /i386/vmgenid/vmgenid/set-guid:                                      **
> ERROR:/builddir/build/BUILD/qemu-2.10.0/tests/vmgenid-test.c:62:acpi_find_vgia:
>  assertion failed (ACPI_ASSERT_CMP_str == "RSDT"): ("" == "RSDT")
> FAIL

Bummer. Sorry, I've should have run the whole test suite afterwards, I
only checked the bios-tables-test :-/

I'll send a v2 with a fix...

 Thomas