[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5 for-2.11?] qcow2: reject unaligned offsets i
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/5 for-2.11?] qcow2: reject unaligned offsets in write compressed |
Date: |
Tue, 14 Nov 2017 10:50:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/14/2017 04:16 AM, Anton Nefedov wrote:
> Misaligned compressed write is not supported.
>
> Signed-off-by: Anton Nefedov <address@hidden>
> ---
> block/qcow2.c | 4 ++++
> 1 file changed, 4 insertions(+)
Should this one be applied in 2.11?
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 92cb9f9..45c5651 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3349,6 +3349,10 @@ qcow2_co_pwritev_compressed(BlockDriverState *bs,
> uint64_t offset,
> return bdrv_truncate(bs->file, cluster_offset, PREALLOC_MODE_OFF,
> NULL);
> }
>
> + if (offset_into_cluster(s, offset)) {
> + return -EINVAL;
> + }
> +
> buf = qemu_blockalign(bs, s->cluster_size);
> if (bytes != s->cluster_size) {
> if (bytes > s->cluster_size ||
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature