[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned off
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache |
Date: |
Tue, 14 Nov 2017 16:09:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 2017-11-14 16:06, Alberto Garcia wrote:
> On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote:
>> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s,
>> Qcow2Cache *c)
>> +{
>> + if (c == s->refcount_block_cache) {
>> + return "refcount block";
>> + } else if (c == s->l2_table_cache) {
>> + return "L2 table";
>> + } else {
>> + /* Do not abort, because this is not critical */
>> + return "unknown";
>> + }
>> +}
>
> Why is an unknown cache not critical?
Because this is debugging information. I know others disagree with my
opinion that I'd rather not abort qemu just because someone forgot to
add a 'return "foo";' here when adding a new cache, but that's my
opinion so I wanted to at least be told by someone that we should abort
here before doing it.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset(), (continued)
[Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache, Max Reitz, 2017/11/10
Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache, Alberto Garcia, 2017/11/14
Re: [Qemu-devel] [PATCH for-2.11 0/5] qcow2: Fixes for corrupted images, Max Reitz, 2017/11/10
Re: [Qemu-devel] [PATCH for-2.11 0/5] qcow2: Fixes for corrupted images, Max Reitz, 2017/11/15