[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 1/3] qapi: Add qdict_is_nu
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 1/3] qapi: Add qdict_is_null() |
Date: |
Tue, 14 Nov 2017 15:15:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 2017-11-14 15:07, Alberto Garcia wrote:
> On Fri 10 Nov 2017 11:13:27 PM CET, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> include/qapi/qmp/qdict.h | 1 +
>> qobject/qdict.c | 10 ++++++++++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
>> index fc218e7be6..c65ebfc748 100644
>> --- a/include/qapi/qmp/qdict.h
>> +++ b/include/qapi/qmp/qdict.h
>> @@ -76,6 +76,7 @@ int64_t qdict_get_try_int(const QDict *qdict, const char
>> *key,
>> int64_t def_value);
>> bool qdict_get_try_bool(const QDict *qdict, const char *key, bool
>> def_value);
>> const char *qdict_get_try_str(const QDict *qdict, const char *key);
>> +bool qdict_is_qnull(const QDict *qdict, const char *key);
>
> I found this name a bit confusing, how about something like
> qdict_entry_is_qnull() ?
Yes, that sounds better. Thanks!
Max
> I'm fine if you want to keep it like this though,
>
> Reviewed-by: Alberto Garcia <address@hidden>
>
> Berto
>
signature.asc
Description: OpenPGP digital signature