[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global |
Date: |
Mon, 13 Nov 2017 09:19:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/10/2017 08:53 PM, Emilio G. Cota wrote:
> 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24)
> introduces a per-CPUClass bool that we check so that the target CPU
> is initialized for TCG only once. This works well except when
> we end up creating more than one CPUClass, in which case we end
> up incorrectly initializing TCG more than once, i.e. once for
> each CPUClass.
... more than one CPUClass for a given translator.
Ideally, cortex-r5 and cortex-a53 would have a common parent class which would
hold all of the bits that are common between them, including the translator.
That said,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11, Emilio G. Cota, 2017/11/10
- [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global, Emilio G. Cota, 2017/11/10
- [Qemu-devel] [PATCH for 2.11 3/5] xlnx-zcu102: Add an info message deprecating the EP108, Emilio G. Cota, 2017/11/10
- [Qemu-devel] [PATCH for 2.11 4/5] xlnx-zcu102: Specify the max number of CPUs for the EP108, Emilio G. Cota, 2017/11/10
- [Qemu-devel] [PATCH for 2.11 5/5] hw: add .min_cpus and .default_cpus fields to machine_class, Emilio G. Cota, 2017/11/10
- [Qemu-devel] [PATCH for 2.11 2/5] xlnx-zynqmp: Properly support the smp command line option, Emilio G. Cota, 2017/11/10
- Re: [Qemu-devel] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11, Peter Maydell, 2017/11/13