[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reo
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare() |
|
Date: |
Fri, 10 Nov 2017 18:47:42 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 10.11.2017 um 18:36 hat Max Reitz geschrieben:
> On 2017-11-10 10:16, Markus Armbruster wrote:
> > Max Reitz <address@hidden> writes:
> >
> >> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> >> not necessarily correct. This series introduces a new qobject_is_equal()
> >> function which can be used to test whether any options have changed,
> >> independently of their type.
> >
> > Series looks ready to me. It touches QAPI to achieve its purpose in the
> > block layer; I'd be fine with merging it via a block tree.
>
> Thanks! So now it's my problem to figure out whether this is 2.11
> material...? :-)
The test case in patch 5 segfaults without the series. Why would it not
be a bug fix (= 2.11 material)?
Kevin
signature.asc
Description: PGP signature