[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] iotests: Make some tests less
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] iotests: Make some tests less flaky |
Date: |
Thu, 9 Nov 2017 16:06:30 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Nov 09, 2017 at 02:37:59AM +0100, Max Reitz wrote:
> There are a couple of tests that fail (on my machine) from time to
> time (and by that I mean that recently I've rarely ever had a test run
> with both 083 and 136 working on first try).
> This series should fix most (at least the issues I am aware of).
>
> Notes:
> - 083 might have another issue, but if so it occurs extremely rarely and
> so I was unable to debug it.
>
> - 129 is flaky, too, because it tries to use block jobs with BB
> throttling -- however, block jobs ignore that these days. Making it
> use a throttle filter node will require quite a bit of work. See
> http://lists.nongnu.org/archive/html/qemu-block/2017-11/msg00111.html
> for more.
>
> - 194 sometimes hangs because the source VM fails to drain its drive.
> This is probably not an issue with the test, but actually an issue in
> qemu. See
> http://lists.nongnu.org/archive/html/qemu-block/2017-11/msg00256.html
> for more.
>
>
> "All tests have passed, let's ship it!"
> -- Me, 2:36 am
>
>
> (Editor's note: "all" means raw/file, qcow2/file, and raw/nbd.)
>
>
> Max Reitz (5):
> iotests: Make 030 less flaky
> iotests: Add missing 'blkdebug::' in 040
> iotests: Make 055 less flaky
> iotests: Make 083 less flaky
> iotests: Make 136 less flaky
>
> tests/qemu-iotests/030 | 8 ++++++--
> tests/qemu-iotests/040 | 2 +-
> tests/qemu-iotests/055 | 25 ++++++++++++++++---------
> tests/qemu-iotests/083 | 3 ++-
> tests/qemu-iotests/136 | 14 +++++++++++++-
> 5 files changed, 38 insertions(+), 14 deletions(-)
>
> --
> 2.13.6
>
>
Thanks for these fixes! QEMU 2.11 material.
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky, (continued)