[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.12 v2 08/12] spapr: remove the use of ics_vali
From: |
Cédric Le Goater |
Subject: |
[Qemu-devel] [PATCH for-2.12 v2 08/12] spapr: remove the use of ics_valid_irq() |
Date: |
Thu, 9 Nov 2017 11:14:35 +0100 |
ics_valid_irq() can be replaced by a simple check on the 'srcno'
number. It also removes a dependency on the ICSState object of the
sPAPR machine.
Signed-off-by: Cédric Le Goater <address@hidden>
---
hw/ppc/spapr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 6c3fc12ed8e1..0c6a4c8bffc0 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3619,11 +3619,10 @@ static int spapr_irq_alloc_block(XICSFabric *xi, int
count, int align)
static void spapr_irq_free_block(XICSFabric *xi, int irq, int num)
{
sPAPRMachineState *spapr = SPAPR_MACHINE(xi);
- ICSState *ics = spapr->ics;
int srcno = irq - spapr->irq_base;
int i;
- if (ics_valid_irq(ics, irq)) {
+ if (srcno >= 0 && srcno < spapr->nr_irqs) {
trace_spapr_irq_free(0, irq, num);
for (i = srcno; i < srcno + num; ++i) {
if (!test_bit(i, spapr->irq_map)) {
--
2.13.6
- [Qemu-devel] [PATCH for-2.12 v2 00/12] spapr: introduce an IRQ allocator at the machine level, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 01/12] spapr: add pseries 2.12 machine type, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 02/12] ppc/xics: remove useless if condition, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 03/12] spapr: introduce new XICSFabric operations for an IRQ allocator, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 04/12] spapr: move current IRQ allocation under the machine, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 05/12] spapr: introduce an IRQ allocator using a bitmap, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 06/12] spapr: store a reference IRQ bitmap, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 07/12] spapr: introduce an 'irq_base' number, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 08/12] spapr: remove the use of ics_valid_irq(),
Cédric Le Goater <=
- [Qemu-devel] [PATCH for-2.12 v2 09/12] spapr: introduce a XICSFabric irq_is_lsi() operation, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 10/12] spapr: split the IRQ number space for LSI interrupts, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 11/12] sparp: merge ics_set_irq_type() in irq_alloc_block() operation, Cédric Le Goater, 2017/11/09
- [Qemu-devel] [PATCH for-2.12 v2 12/12] spapr: use sPAPRMachineState in spapr_ics_ prototypes, Cédric Le Goater, 2017/11/09
- Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.12 v2 00/12] spapr: introduce an IRQ allocator at the machine level, Cédric Le Goater, 2017/11/09