Re: [Qemu-devel] [PATCH] hw/pcie-pci-bridge: restrict to X86 and ARM

[Thomas Huth]

On 08.11.2017 16:20, Marcel Apfelbaum wrote:
> The PCIE-PCI bridge is specific to "pure" PCI systems

s/PCI/PCIe/ ?

> (on QEMU we have X86 and ARM), it does not make sense to
> have if in other archs.
> 
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>  default-configs/arm-softmmu.mak    | 1 +
>  default-configs/i386-softmmu.mak   | 1 +
>  default-configs/x86_64-softmmu.mak | 1 +
>  hw/pci-bridge/Makefile.objs        | 3 ++-
>  4 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..33934b1dc4 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -122,6 +122,7 @@ CONFIG_FSL_IMX25=y
>  CONFIG_IMX_I2C=y
>  
>  CONFIG_PCIE_PORT=y
> +CONFIG_PCIE_PCI_BRIDGE=y

Actually, why not simply use CONFIG_PCIE_PORT instead to determine
whether the PCIe-to-PCI bridge should be included? The device only makes
sense if there is a PCIe root port available on the system...

 Thomas