Re: [Qemu-devel] i440/piix and dynamic sysbus check

[Marc-André Lureau]

Hi Eduardo

On Tue, Nov 7, 2017 at 5:53 PM, Eduardo Habkost <address@hidden> wrote:
> On Tue, Nov 07, 2017 at 05:40:17PM +0100, Marc-André Lureau wrote:
>> Hi,
>>
>> I am working on a TPM CRB device (last sent version:
>> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02014.html).
>> It's a sysbus device, and when starting qemu with i440, I get "Option
>> '-device tpm-crb' cannot be handled by this machine".
>>
>> The check comes from machine_init_notify(), checking that the machine
>> has_dynamic_sysbus.
>>
>>  Apparently, q35 supports it. But not i440. If I declare
>> has_dynamic_sysbus in piix, the device works fine.
>
> Before doing that, I would like to replace has_dynamic_sysbus
> with a whitelist, so we don't need to make the machine accept all
> other sysbus devices too.
>
> I probably should rebase and resubmit this RFC:
> http://mid.mail-archive.com/address@hidden
> Subject: [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type  
> whitelist

Looks good. I'll assume the problem will be eventually resolved after
your series. Looking forward to it.

Thanks




-- 
Marc-André Lureau