qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash informatio


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash information
Date: Tue, 7 Nov 2017 13:35:44 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 11/07/2017 05:00 AM, QingFeng Hao wrote:

>>> +
>>> +##
>>> +# @GuestPanicInformationS390:
>>> +#
>>> +# S390 specific guest panic information (PSW)
>>> +#
>>> +# Since: 2.11
>>> +##
>>> +{'struct': 'GuestPanicInformationS390',
>>> + 'data': { 'psw-mask': 'uint64',
>>> +           'psw-addr': 'uint64',
>>> +           'reason': 'str' } }
>> Missing documentation of the three fields; in particular, whether
> I didn't get your point, do you mean we need to add comments
> for the three fields? But I don't see the comments for Hyper-V either.

Your mailer is eating blank lines, which makes it harder to visually
distinguish where quoting ends and where new content begins (I had a
blank line between your "'reason': 'str' } }" content and my "Missing
documentation..." comment).

I mean something like:

##
# @GuestPanicInformationS390:
#
# S390 specific guest panic information (PSW)
#
# @psw-mask: <description of what this mask represents>
# @psw-addr: Address that was accessed to cause the panic
# @reason: Human-readable explanation of the panic (should not be parsed
#          by a machine)
#
# Since: 2.11
##

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]