Re: [Qemu-devel] [PATCH] build: remove use of MAKELEVEL optimization in submodule handling

[Eric Blake]

On 11/06/2017 05:41 AM, Daniel P. Berrange wrote:
> The Makefile attempts to optimize the handling of submodules by using 
> MAKELEVEL
> to only check the submodule status when running from the top level make
> invokation. This causes problems for people who are using a makefile of their

s/invokation/invocation/

> own to in turn invoke QEMU's makefile, as MAKELEVEL is already set to 1 (or
> more) when QEMU's makefile runs.
> 
> This optimization should not really be needed, since the git-submodule.sh
> script is already used to detect if a submodule update is required. This by

s/This/Thus/

> removing the MAKELEVEL check, we at most add an extra 'git-submodule.sh 
> status'
> call to each make level, the overhead of which is lost in noise of building
> QEMU.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> 
> NB this is on top of 
> https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg00449.html

Or in wording understood by patchew:

Based-on:
https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg00449.html

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature