[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] chardev: fix backend events regression w
|
From: |
Kirill A. Shutemov |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] chardev: fix backend events regression with mux chardev |
|
Date: |
Fri, 3 Nov 2017 18:59:17 +0300 |
|
User-agent: |
NeoMutt/20170714-126-deb55f (1.8.3) |
On Fri, Nov 03, 2017 at 03:28:23PM +0000, Marc-André Lureau wrote:
> Kirill noticied that on recent versions on QEMU he was not able to
> trigger SysRq to invoke debug capabilites of Linux Kernel. He tracked
> it down to qemu_chr_be_event() ignoring CHR_EVENT_BREAK due s->be
> being NULL. The bug was introduced in 2.8, commit a4afa548fc6d ("char:
> move front end handlers in CharBackend"). Since the commit, the
> qemu_chr_be_event() failed to deliver CHR_EVENT_BREAK due to
> qemu_chr_fe_init() does not set s->be in case of mux.
>
> Let's fix this by teaching mux to send an event to the frontend with
> the focus.
>
> Reported-by: Kirill A. Shutemov <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend")
Works for me.
Tested-by: Kirill A. Shutemov <address@hidden>
--
Kirill A. Shutemov