[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 08/26] replay: make safe vmstop at record/re
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 08/26] replay: make safe vmstop at record/replay |
Date: |
Thu, 2 Nov 2017 13:00:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 02/11/2017 12:57, Pavel Dovgalyuk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 31/10/2017 12:25, Pavel Dovgalyuk wrote:
>>>
>>> - bdrv_drain_all();
>>> - replay_disable_events();
>>> - ret = bdrv_flush_all();
>>> + if (!replay_events_enabled()) {
>>> + bdrv_drain_all();
>>> + ret = bdrv_flush_all();
>>> + }
>>>
>>> return ret;
>>> }
>>> diff --git a/migration/savevm.c b/migration/savevm.c
>>> index 20cebe1..41a13c0 100644
>>> --- a/migration/savevm.c
>>> +++ b/migration/savevm.c
>>> @@ -2143,8 +2143,8 @@ int save_snapshot(const char *name, Error **errp)
>>> AioContext *aio_context;
>>>
>>> if (!replay_can_snapshot()) {
>>> - monitor_printf(mon, "Record/replay does not allow making snapshot "
>>> - "right now. Try once more later.\n");
>>> + error_report("Record/replay does not allow making snapshot "
>>> + "right now. Try once more later.\n");
>>
>> Why this change?
>
> Kind of a mess in changes.
> It should be in patch 06 which introduce these lines.
> I'll fix it in the next version.
No problem. Remember to delete the \n too since otherwise patchew
complains.
Paolo