qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in Q


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in QIOChannelFile
Date: Wed, 1 Nov 2017 19:11:01 +0100

On Wed, Nov 1, 2017 at 3:25 PM, Ross Lagerwall
<address@hidden> wrote:
> If the file descriptor underlying QIOChannelFile is closed in the
> io_close() method, don't close it again in the finalize() method since
> the file descriptor number may have been reused in the meantime.
>
> Signed-off-by: Ross Lagerwall <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>


> ---
> New in v2.
>
>  io/channel-file.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/io/channel-file.c b/io/channel-file.c
> index 16bf7ed..1f2f710 100644
> --- a/io/channel-file.c
> +++ b/io/channel-file.c
> @@ -178,6 +178,7 @@ static int qio_channel_file_close(QIOChannel *ioc,
>                           "Unable to close file");
>          return -1;
>      }
> +    fioc->fd = -1;
>      return 0;
>  }
>
> --
> 2.9.5
>
>



-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]