[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay |
Date: |
Tue, 31 Oct 2017 13:48:24 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables bdrv flush/drain in record/replay mode.
When block request is in the replay queue it cannot be processed
with drain/flush until it is found in the log.
Therefore vm should just stop leaving unfinished operations
in the queue.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
cpus.c | 7 ++++---
migration/savevm.c | 4 ++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/cpus.c b/cpus.c
index 114c29b..c728f3a 100644
--- a/cpus.c
+++ b/cpus.c
@@ -942,9 +942,10 @@ static int do_vm_stop(RunState state)
qapi_event_send_stop(&error_abort);
}
- bdrv_drain_all();
- replay_disable_events();
- ret = bdrv_flush_all();
+ if (!replay_events_enabled()) {
+ bdrv_drain_all();
+ ret = bdrv_flush_all();
+ }
return ret;
}
diff --git a/migration/savevm.c b/migration/savevm.c
index 20cebe1..41a13c0 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2143,8 +2143,8 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (!replay_can_snapshot()) {
- monitor_printf(mon, "Record/replay does not allow making snapshot "
- "right now. Try once more later.\n");
+ error_report("Record/replay does not allow making snapshot "
+ "right now. Try once more later.\n");
return ret;
}
- [Qemu-devel] [RFCPATCH00/20] replay additions, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH01/20] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH02/20] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH03/20] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH04/20] replay: fix processing async events, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH05/20] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH07/20] replay: added replay log format description, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFCPATCH09/20] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH11/20] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH12/20] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH13/20] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH14/20] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH16/20] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH17/20] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/10/31
- [Qemu-devel] [RFCPATCH18/20] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/10/31