Re: [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on 
error
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2c0ad7d947 qga-win: report specific error when failing to open channel
0201eef61d qga-win: install service with --retry-path set by default
432d6851ff qga: add --retry-path option for re-initializing channel on failure
d242b19057 qga: move w32 service handling out of run_agent()
522ea4562e qga: hang GAConfig/socket_activation off of GAState global
615c58083f qga: group agent init/cleanup init separate routines

=== OUTPUT BEGIN ===
Checking PATCH 1/6: qga: group agent init/cleanup init separate routines...
ERROR: Use g_assert or g_assert_not_reached
#29: FILE: qga/main.c:1257:
+    g_assert_null(ga_state);

total: 1 errors, 0 warnings, 143 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: qga: hang GAConfig/socket_activation off of GAState 
global...
Checking PATCH 3/6: qga: move w32 service handling out of run_agent()...
Checking PATCH 4/6: qga: add --retry-path option for re-initializing channel on 
failure...
Checking PATCH 5/6: qga-win: install service with --retry-path set by default...
Checking PATCH 6/6: qga-win: report specific error when failing to open 
channel...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden