[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help |
Date: |
Thu, 26 Oct 2017 12:38:33 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 26/10/17 12:29, Alexey Kardashevskiy wrote:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>
> address@hidden:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep
> kernel-irqchip
>
> Was:
> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>
> Now:
> pseries-2.11.kernel-irqchip=On|Off|Split (Configure KVM in-kernel irqchip)
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 36c2fb069c..ea89cf706e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void
> *data)
> object_class_property_set_description(oc, "accel",
> "Accelerator list", &error_abort);
>
> - object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
> + object_class_property_add(oc, "kernel-irqchip", "On|Off|Split",
ah, only small case letters are allowed actually, v2 with "on|off|split" is
coming.
> NULL, machine_set_kernel_irqchip,
> NULL, NULL, &error_abort);
> object_class_property_set_description(oc, "kernel-irqchip",
>
--
Alexey